Skip to content

Commit

Permalink
refactor: remove references and artifacts for data sets (#2041)
Browse files Browse the repository at this point in the history
* refactor: remove references and artifacts for data sets

* revert: change baseUrl in cypress config

* refactor: remove data set from sp service classes

* refactor: use data source for data explorer
  • Loading branch information
bossenti authored Oct 20, 2023
1 parent 3299dd8 commit f1d8639
Show file tree
Hide file tree
Showing 22 changed files with 14 additions and 55 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ public enum SpServiceTagPrefix {
ADAPTER("adapter"),
DATA_STREAM("dstream"),
DATA_PROCESSOR("dprocessor"),
DATA_SINK("dsink"),
DATA_SET("dset");
DATA_SINK("dsink");

private String prefix;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class SpServicePathPrefix {
public static final String DATA_PROCESSOR = "sepa";
public static final String DATA_SINK = "sec";
public static final String DATA_STREAM = "stream";
public static final String DATA_SET = "set";
public static final String ADAPTER = "api/v1/worker/adapters";
public static final String PROTOCOL = "api/v1/worker/protocols";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ public enum SpServiceUrlProvider {
DATA_PROCESSOR(SpServicePathPrefix.DATA_PROCESSOR, SpServiceTagPrefix.DATA_PROCESSOR),
DATA_SINK(SpServicePathPrefix.DATA_SINK, SpServiceTagPrefix.DATA_SINK),
DATA_STREAM(SpServicePathPrefix.DATA_STREAM, SpServiceTagPrefix.DATA_STREAM),
DATA_SET(SpServicePathPrefix.DATA_SET, SpServiceTagPrefix.DATA_SET),
ADAPTER(SpServicePathPrefix.ADAPTER, SpServiceTagPrefix.ADAPTER);

private final String http = "http://";
Expand Down
2 changes: 1 addition & 1 deletion ui/cypress/tests/adapter/editAdapter.smoke.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe('Test Edit Adapter', () => {

ConnectUtils.startAndValidateAdapter(3);

// Validate that name of adapter and data source
// Validate that name of adapter and data stream
cy.dataCy('adapter-name').contains(newAdapterName);
cy.get('.sp-dialog-content').contains(newAdapterName);
});
Expand Down
3 changes: 1 addition & 2 deletions ui/deployment/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ $sp-color-accent-light-transparent: rgba(156, 156, 156, 0.4);
$sp-color-accent-dark: #83a3de;

$sp-color-stream: #ffeb3b;
$sp-color-set: #ffa23b;
$sp-color-processor: #009688;
$sp-color-sink: #3f51b5;

Expand All @@ -38,7 +37,7 @@ body {
--color-data-view: rgb(122, 206, 227);
--color-dashboard: rgb(76, 115, 164);
--color-adapter: rgb(182, 140, 97);
--color-data-source: #ffa23b;
--color-data-source: #ffeb3b;
--color-pipeline: rgb(102, 185, 114);
--color-measurement: rgb(39, 164, 155);
--color-file: rgb(163, 98, 190);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,6 @@ export class EndpointItemComponent implements OnInit {
const baseType = 'pe-label ';
if (this.item.type === 'stream') {
this.itemTypeStyle = baseType + 'stream-label';
} else if (this.item.type === 'set') {
this.itemTypeStyle = baseType + 'set-label';
} else if (this.item.type === 'sepa') {
this.itemTypeStyle = baseType + 'processor-label';
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
class="link-configuration"
>
<mat-form-field color="accent" fxFlex="100">
<mat-label>Data Source</mat-label>
<mat-label>Data Stream</mat-label>
<mat-select
(selectionChange)="
changeLabel(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
<div fxLayout="row" fxLayoutAlign="start center" class="mb-10">
<div fxLayout="row" fxLayoutAlign="start center">
<span class="general-options-header mb-0"
>Data Sources</span
>Data Streams</span
>
</div>
<div fxLayout="row" fxLayoutAlign="end center" fxFlex>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ <h4>Exported items {{ config.assetName }}</h4>
></sp-data-export-item>
<sp-data-export-item
[exportItems]="config.dataSources"
sectionTitle="Data Sources"
sectionTitle="Data Streams"
></sp-data-export-item>
<sp-data-export-item
[exportItems]="config.dataLakeMeasures"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ <h4>Select resources to import</h4>
></sp-data-export-item>
<sp-data-export-item
[exportItems]="importConfiguration.dataSources"
sectionTitle="Data Sources"
sectionTitle="Data Streams"
></sp-data-export-item>
<sp-data-export-item
[exportItems]="importConfiguration.dataLakeMeasures"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<div fxLayout="row" fxLayoutAlign="center center" fxFlex="100">
<div fxLayoutAlign="start center" class="error-text">
&nbsp;There was an error while guessing the schema of your
configured data source:
configured data stream:
</div>
</div>
<div fxLayout="row" fxLayoutAlign="center center" class="mt-10">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,6 @@ ul {
opacity: 1 !important;
}

.historic {
cursor: pointer;
color: #ffa23b;
}
.real-time {
cursor: pointer;
color: #ffeb3b;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@
max-height: 50px;
max-width: 80%;
}
.historic {
cursor: pointer;
color: #ffa23b;
}
.real-time {
cursor: pointer;
color: #ffeb3b;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@
.adapter-icon {
max-height: 50px;
}

.historic {
cursor: pointer;
color: #ffa23b;
}
.real-time {
cursor: pointer;
color: #ffeb3b;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,8 @@ export class PipelineElementIconStandComponent
{
availableTypes = [
{
title: 'Data Sources',
filters: [
PipelineElementType.DataStream,
PipelineElementType.DataSet,
],
title: 'Data Streams',
filters: [PipelineElementType.DataStream],
open: true,
color: 'var(--color-stream)',
sort: 'name',
Expand Down
1 change: 0 additions & 1 deletion ui/src/app/editor/model/editor.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ export interface PipelineElementRecommendationLayout {
}

export enum PipelineElementType {
DataSet,
DataStream,
DataProcessor,
DataSink,
Expand Down
2 changes: 0 additions & 2 deletions ui/src/app/editor/utils/editor.utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ export class PipelineElementTypeUtils {
static toCssShortHand(elementType: PipelineElementType) {
if (PipelineElementType.DataStream === elementType) {
return 'stream';
} else if (PipelineElementType.DataSet === elementType) {
return 'set';
} else if (PipelineElementType.DataProcessor === elementType) {
return 'sepa';
} else {
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/services/tour/adapter-tour-2.constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export default {
{
stepId: 'step-9',
title: 'Congratulation',
text: 'Congratulation you have created your first adapter and finished the tutorial. Go to the pipeline editor to see the new data source',
text: 'Congratulation you have created your first adapter and finished the tutorial. Go to the pipeline editor to see the new data stream',
classes: 'shepherd shepherd-welcome',
buttons: ['cancel'],
},
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/services/tour/adapter-tour-3.constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export default {
{
stepId: 'step-9',
title: 'Congratulation',
text: 'Congratulation you have created your second adapter and finished the tutorial. Go to the pipeline editor to see the new data source',
text: 'Congratulation you have created your second adapter and finished the tutorial. Go to the pipeline editor to see the new data stream',
classes: 'shepherd shepherd-welcome',
buttons: ['cancel'],
},
Expand Down
4 changes: 2 additions & 2 deletions ui/src/app/services/tour/adapter-tour.constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export default {
title: 'Adapter was started successfully',
text:
'<p>The adpater is now deployed in the background and the data is fetched and processed from the OpenSenseMap endpoint. Here you will see some example data, which is coming directly ' +
'the data source. This might take a minute. On the left you can see the runtime names of the properties you defined before. On the right side the values are shown. After having a look at ' +
'displayed from the data stream. This might take a minute. On the left you can see the runtime names of the properties you defined before. On the right side the values are shown. After having a look at ' +
'the data <b>click on Close</b> to continue.</p>',
attachToElement: '#confirm_adapter_started_button',
attachPosition: 'bottom',
Expand All @@ -99,7 +99,7 @@ export default {
{
stepId: 'step-9',
title: 'Congratulation',
text: '<b></b>Congratulation!</b> You have created your first adapter and finished the tutorial. Go to the pipeline editor to see the new data source',
text: '<b></b>Congratulation!</b> You have created your first adapter and finished the tutorial. Go to the pipeline editor to see the new data stream',
classes: 'shepherd shepherd-welcome',
buttons: ['cancel'],
},
Expand Down
11 changes: 0 additions & 11 deletions ui/src/scss/sp/main.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ body {
height: auto !important;
width: 100%;

--color-set: #{$sp-color-set};
--color-stream: #{$sp-color-stream};
--color-processor: #{$sp-color-processor};
--color-sink: #{$sp-color-sink};
Expand Down Expand Up @@ -531,11 +530,6 @@ md-content {
color: black;
}

.set-label {
background: $sp-color-set;
color: black;
}

.processor-label {
background: $sp-color-processor;
}
Expand All @@ -549,11 +543,6 @@ md-content {
border: 2px solid $sp-color-stream;
}

.set {
border-radius: 50%;
border: 2px solid $sp-color-set;
}

.action {
border: 2px solid $sp-color-sink;
}
Expand Down
5 changes: 0 additions & 5 deletions ui/src/scss/sp/pipeline-element-options.scss
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,3 @@
background: $sp-color-stream;
color: #343434;
}

.pe-info-set {
background: $sp-color-set;
color: white;
}

0 comments on commit f1d8639

Please sign in to comment.