Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove magic HTTP numbers in StreamPipes #2092

Closed
bossenti opened this issue Oct 27, 2023 · 2 comments · Fixed by #2099
Closed

Remove magic HTTP numbers in StreamPipes #2092

bossenti opened this issue Oct 27, 2023 · 2 comments · Fixed by #2099
Assignees
@bagechengzi
Labels
backend Everything that is related to the StreamPipes backend enhancement New feature or request good first issue Good for newcomers refactoring Indicates when a pull request or issue contains larger refactoring aspects.
Milestone
0.93.0

Comments

@bossenti
Copy link
Contributor

Body

Due to some legacy reasons, we have HTTP status codes as hard-coded strings, e.g., "200" at multiple places in our code base.
To increase maintainability and readability, we want to replace all of these magic numbers by values of org.apache.http.HttpStatus.

The purpose of this issue is to remove all occurrences of hard-coded HTTP results and replace them with the corresponding values of HttpStatus code.

Mentoring

As this issue is marked as a good first issue: one of @dominikriemer, @tenthe, or @bossenti are happy to provide help for getting started, just tag (one of) them if you want to start working on this issue and need some help.
This issue is ideal for people who want to dip their toes in the water of open source contributions.

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
@bossenti bossenti added this to the 0.95.0 milestone Oct 27, 2023
@bossenti bossenti added enhancement New feature or request refactoring Indicates when a pull request or issue contains larger refactoring aspects. backend Everything that is related to the StreamPipes backend good first issue Good for newcomers labels Oct 27, 2023
@bagechengzi
Copy link
Contributor

Hello, I would like to contribute, can you please assign this issue to me?

@bossenti
Copy link
Contributor Author

great to hear @bagechengzi 🎉

@bagechengzi bagechengzi mentioned this issue Oct 27, 2023
Merged
@bossenti bossenti linked a pull request Oct 27, 2023 that will close this issue
refactor(#2092): Use HttpStatus in stead of plain strings #2099
Merged
dominikriemer pushed a commit that referenced this issue Oct 30, 2023
@bagechengzi
refactor(#2092): Use HttpStatus in stead of plain strings (#2099)
0497444 
* remove occurrences of hard-coded HTTP results and replace them with the corresponding values of code.HttpStatus

* resolve checkstyle violation

* resolve checkstyle violation2

* After testing,resolve checkstyle violation

* modify

* modify
@bossenti bossenti modified the milestones: 0.95.0, 0.93.0 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagechengzi bagechengzi

Labels
backend Everything that is related to the StreamPipes backend enhancement New feature or request good first issue Good for newcomers refactoring Indicates when a pull request or issue contains larger refactoring aspects.
Projects
None yet
Milestone
0.93.0
Development

Successfully merging a pull request may close this issue.

refactor(#2092): Use HttpStatus in stead of plain strings bagechengzi/streampipes
2 participants
@bossenti @bagechengzi