Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(#2092): Use HttpStatus in stead of plain strings #2099

Merged
merged 8 commits into from
Oct 30, 2023
Merged

refactor(#2092): Use HttpStatus in stead of plain strings #2099

merged 8 commits into from
Oct 30, 2023

Conversation

bagechengzi
Copy link
Contributor

…the corresponding values of code.HttpStatus

Purpose

Remove occurrences of hard-coded HTTP results and replace them with the corresponding values of HttpStatus code.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code connect Related to the `connect` module (adapters) backend Everything that is related to the StreamPipes backend testing Relates to any kind of test (unit test, integration, or E2E test). labels Oct 27, 2023
@bagechengzi
Copy link
Contributor Author

#2092

dominikriemer
dominikriemer approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@dominikriemer dominikriemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @bagechengzi !

@bossenti bossenti linked an issue Oct 27, 2023 that may be closed by this pull request
Remove magic HTTP numbers in StreamPipes #2092
Closed
@bossenti bossenti changed the title remove occurrences of hard-coded HTTP results and replace them with … refactor(#2092): Use HttpStatus in stead of plain strings Oct 27, 2023
@tenthe
Copy link
Contributor

tenthe commented Oct 27, 2023

Hi @bagechengzi,
thanks for providing this PR.
There are a few checkstyle violations that caused the PR validation to fail.

Error:  src/main/java/org/apache/streampipes/client/api/AbstractTypedClientApi.java:[21,1] (imports) ImportOrder: Import org.apache.streampipes.client.http.GetRequest appears after other imports that it should precede
Error:  src/main/java/org/apache/streampipes/client/api/AbstractClientApi.java:[21,1] (imports) ImportOrder: Import org.apache.streampipes.client.http.DeleteRequest appears after other imports that it should precede
Error:  src/main/java/org/apache/streampipes/client/http/HttpRequest.java:[109] (sizes) LineLength: Line is longer than 120 characters (found 124).

Once they are resolved, we can merge the PR.

Cheers,
Philipp

@bagechengzi

This comment was marked as outdated.

Sign in to view
@dominikriemer dominikriemer merged commit 0497444 into apache:dev Oct 30, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bossenti bossenti bossenti approved these changes

@dominikriemer dominikriemer dominikriemer approved these changes

@tenthe tenthe tenthe approved these changes

Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend connect Related to the `connect` module (adapters) dependencies Pull requests that update a dependency file java Pull requests that update Java code testing Relates to any kind of test (unit test, integration, or E2E test).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove magic HTTP numbers in StreamPipes
4 participants
@bagechengzi @tenthe @dominikriemer @bossenti