-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protected names are not sanitized correctly in Data Lake Sink / Influx sink #2166
Comments
Hi @bossenti, I have looked into the issue. The event is "correct" ("correct" meaning key value pairs are the same with the file) in frontend, Kafka producer, and Kafka consumer. However, once the code hits Influx Store, the runtime name of some keys are modified. The root cause is that "name" key in the file stream is a keyword of Influx reserved keywords list and Streampipes sanitizes DataLake measure for those keys conflicting with Influx reserved keywords. If you change "name" to something else not in the list everything works. To fix this, I propose to also sanitize event instead of only sanitizing DataLake measure. Let me know what do you think🙂! |
Hi @muyangye, you are right, changing the column name makes it work. As you said, sanitation should prevent naming conflicts and therefore rename the Where would you place the sanitation of the event? Sanitation is a specific requirement of the InfluxDb in this case, so I'm a bit hesitant to affect other usages of the event stream as well. |
Just published a PR! The scope of the sanitization is limited to InfluxDb. |
* implement new round processor * add English locale, icon, and documentation * fix checkstyle * support different rounding modes * add rounding mode in documentation * fix time display * let NaryMapping selection account for property scope * implement boolean filter unit tests * add common StoreEventCollector class and refactor TestChangedValueDetectionProcessor * add new class * show associated pipelines' names and allow one click deletion * center text * fix minor error * replace magic number * add timeout * restore newline * changeb baseurl * revert port * revert timeout * implement pipelines owner check * undo automatic changes * enable admin to delete pipelines no matter ownership * sanitize event * add newline back * fix iter is on a copy --------- Co-authored-by: bossenti <[email protected]>
* implement new round processor * add English locale, icon, and documentation * fix checkstyle * support different rounding modes * add rounding mode in documentation * fix time display * let NaryMapping selection account for property scope * implement boolean filter unit tests * add common StoreEventCollector class and refactor TestChangedValueDetectionProcessor * add new class * show associated pipelines' names and allow one click deletion * center text * fix minor error * replace magic number * add timeout * restore newline * changeb baseurl * revert port * revert timeout * implement pipelines owner check * undo automatic changes * enable admin to delete pipelines no matter ownership * sanitize event * add newline back * fix iter is on a copy --------- Co-authored-by: bossenti <[email protected]>
Apache StreamPipes version
dev (current development state)
Affected StreamPipes components
Connect
What happened?
When reading the following CSV file with the
FileStream
adapter and persisting the created the data stream in the data storage, simple string values are lost.Only string values that are explicitly quoted are kept, but this should not be necessary for a CSV file.
How to reproduce?
Expected behavior
No response
Additional technical information
No response
Are you willing to submit a PR?
None
The text was updated successfully, but these errors were encountered: