-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#2166): sanitize event keys in influx sink #2172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # streampipes-rest/src/main/java/org/apache/streampipes/rest/impl/connect/AdapterResource.java
github-actions
bot
added
java
Pull requests that update Java code
backend
Everything that is related to the StreamPipes backend
labels
Nov 13, 2023
bossenti
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement @muyangye 🙏🏼
bossenti
changed the title
fix(#2166) Sanitize Event Keys
fix(#2166): sanitize event keys in influx sink
Nov 13, 2023
Works like a charm! |
bossenti
added a commit
that referenced
this pull request
Nov 14, 2023
* implement new round processor * add English locale, icon, and documentation * fix checkstyle * support different rounding modes * add rounding mode in documentation * fix time display * let NaryMapping selection account for property scope * implement boolean filter unit tests * add common StoreEventCollector class and refactor TestChangedValueDetectionProcessor * add new class * show associated pipelines' names and allow one click deletion * center text * fix minor error * replace magic number * add timeout * restore newline * changeb baseurl * revert port * revert timeout * implement pipelines owner check * undo automatic changes * enable admin to delete pipelines no matter ownership * sanitize event * add newline back * fix iter is on a copy --------- Co-authored-by: bossenti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
See #2166
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no