Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(#2088): Remove module streampipes-logging #2089

Merged
merged 3 commits into from
Oct 28, 2023
Merged

refactor(#2088): Remove module streampipes-logging #2089

merged 3 commits into from
Oct 28, 2023

Conversation

tenthe
Copy link
Contributor

@tenthe tenthe commented Oct 26, 2023

Description

The streampipes-logging module currently contains legacy code that is no longer in use and should be removed to improve the codebase and remove deprecated components.

Changes Made

  1. Replaced all instances of PeLogger with LoggerFactory.getLogger(ClassToBeLogged.class) for default StreamPipes logging.

  2. Verified that the logging functionality remains intact after the replacement.

  3. Remove module streampipes-logging

Related Issue

Closes #2088

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@tenthe tenthe linked an issue Oct 26, 2023 that may be closed by this pull request
Remove module streampipes-logging #2088
Closed
@github-actions github-actions bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code pipeline elements Relates to pipeline elements backend Everything that is related to the StreamPipes backend labels Oct 26, 2023
bossenti
bossenti approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@bossenti bossenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@bossenti
Copy link
Contributor

There are some leftover references:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project streampipes-wrapper-flink: Compilation failure: Compilation failure: 
Error:  /home/runner/work/streampipes/streampipes/streampipes-wrapper-flink/src/main/java/org/apache/streampipes/wrapper/flink/logger/StatisticLogger.java:[21,43] package org.apache.streampipes.logging.impl does not exist
Error:  /home/runner/work/streampipes/streampipes/streampipes-wrapper-flink/src/main/java/org/apache/streampipes/wrapper/flink/logger/StatisticLogger.java:[38,5] cannot find symbol

@dominikriemer dominikriemer merged commit 89c414f into dev Oct 28, 2023
18 checks passed
@dominikriemer dominikriemer deleted the 2088-remove-module-streampipes-logging branch October 28, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bossenti bossenti bossenti approved these changes

@dominikriemer dominikriemer dominikriemer approved these changes

Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend dependencies Pull requests that update a dependency file java Pull requests that update Java code pipeline elements Relates to pipeline elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove module streampipes-logging
3 participants
@tenthe @bossenti @dominikriemer