-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New E2E-Tests for data view #2154
Conversation
Unfortunately, both tests are flaky: Changing the filter settings throws the error: ResizeObserver loop completed with undelivered notifications. Errors occur when adding a filter (line 55 in table.spec.ts and line 77 in timeSeriesSave.spec.ts) |
Added 5 new Tests for different widgets in data view: Now testing the functionality of table, time series, 2D-correlation, distribution, heatmap, map and indicator. |
}); | ||
|
||
it('Perform Test', () => { | ||
DataLakeUtils.goToDatalake(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setup of this test seems to be the same for each of the widget tests. Can you please extract this in a seperate utils file?
|
||
DataLakeUtils.clickCreateButton(); | ||
|
||
DataLakeUtils.selectTimeRange( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add this also to the new utils function? Maybe it is possible to change the time range before adding the widget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for implementing those tests. I had only one comment regarting the setup code for eacht test. This seems to be very similar. Maybe we can introduce a function in the DataLakeUtils class that is used in eacht test for set up.
cc59282
to
1c2b922
Compare
Done! |
Purpose
Adds two new E2E-Tests for data view: Testing functionality of table view and time series view. Validates that new graphs are displayed correctly and that filtering is working.Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no