Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New E2E-Tests for data view #2154

Merged
merged 9 commits into from
Nov 21, 2023
Merged

New E2E-Tests for data view #2154

merged 9 commits into from
Nov 21, 2023

Conversation

Marcelfrueh
Copy link
Contributor

Purpose

Adds two new E2E-Tests for data view: Testing functionality of table view and time series view. Validates that new graphs are displayed correctly and that filtering is working.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added ui Anything that affects the UI testing Relates to any kind of test (unit test, integration, or E2E test). labels Nov 8, 2023
@Marcelfrueh
Copy link
Contributor Author

Unfortunately, both tests are flaky: Changing the filter settings throws the error: ResizeObserver loop completed with undelivered notifications. Errors occur when adding a filter (line 55 in table.spec.ts and line 77 in timeSeriesSave.spec.ts)

@Marcelfrueh
Copy link
Contributor Author

Added 5 new Tests for different widgets in data view: Now testing the functionality of table, time series, 2D-correlation, distribution, heatmap, map and indicator.
To avoid the error message "ResizeObserver loop completed with undelivered notifications" when adding a filter, the test for the filter is excluded from the UI tests.

@Marcelfrueh Marcelfrueh marked this pull request as ready for review November 15, 2023 16:31
@tenthe tenthe self-requested a review November 15, 2023 17:05
});

it('Perform Test', () => {
DataLakeUtils.goToDatalake();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setup of this test seems to be the same for each of the widget tests. Can you please extract this in a seperate utils file?


DataLakeUtils.clickCreateButton();

DataLakeUtils.selectTimeRange(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add this also to the new utils function? Maybe it is possible to change the time range before adding the widget.

Copy link
Contributor

@tenthe tenthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for implementing those tests. I had only one comment regarting the setup code for eacht test. This seems to be very similar. Maybe we can introduce a function in the DataLakeUtils class that is used in eacht test for set up.

@Marcelfrueh
Copy link
Contributor Author

Done!

@bossenti bossenti added this to the 0.95.0 milestone Nov 21, 2023
@bossenti bossenti added the no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings). label Nov 21, 2023
@bossenti bossenti merged commit 166277f into apache:dev Nov 21, 2023
18 checks passed
@Marcelfrueh Marcelfrueh deleted the dataview-tests branch December 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings). testing Relates to any kind of test (unit test, integration, or E2E test). ui Anything that affects the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants