feat: add streampipes go client #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Good work.
The overall code structure framework looks good to me.
I think it's better to discuss the go client API first. We would better make a consensus on this before we merge this PR.
Could you describe your go client API design in the PR description or in the discussion here?
And is it possible to write some integration tests for the go client? We would also need to run the tests in the CI.
streampipes-client-go/streampipes/internal/config/ClientConnectionConfig.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/StatuCode/ErrorCode.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/StreamPipesHttp/DeleteRequest.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/api/DataLakeMeasureApi.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/model/DataConversion/DataLakeConversion.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/api/DataLakeMeasureApi.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/api/DataStreamApi.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/model/DataLake/DataLakeMeasure.go
Outdated
Show resolved
Hide resolved
wyyolo
changed the title
wyyolo
changed the title
|
At present, some unit tests have been implemented, and data from the Streampipes API can be received normally by connecting to Streampipes. You can refer to the usage of streams client go/streams/examples/main. go |
wyyolo
changed the title
github-actions
bot
added
the
gh-actions
RobertIndie
reviewed
Feb 7, 2024
RobertIndie
reviewed
Feb 18, 2024
streampipes-client-go/streampipes/config/client_connection_config.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/config/client_connection_config.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/util/streampipes_apiPath.go
Outdated
Show resolved
Hide resolved
RobertIndie
reviewed
Mar 4, 2024
RobertIndie
reviewed
Mar 7, 2024
streampipes-client-go/streampipes/config/client_connection_config.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/serializer/deserializer.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/serializer/deserializer.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/streampipes_http/delete_request.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/util/streampipes_api_path.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/util/streampipes_api_path.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/util/streampipes_api_path.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/util/streampipes_api_path_test.go
Outdated
Show resolved
Hide resolved
github-actions
bot
added
java
luoluoyuyu
removed
java
RobertIndie
reviewed
Mar 19, 2024
RobertIndie
reviewed
Mar 19, 2024
RobertIndie
reviewed
Mar 21, 2024
streampipes-client-go/streampipes/internal/serializer/deserializer.go
Outdated
Show resolved
Hide resolved
streampipes-client-go/streampipes/internal/serializer/deserializer.go
Outdated
Show resolved
Hide resolved
RobertIndie
approved these changes
Mar 21, 2024
dominikriemer
approved these changes
Mar 21, 2024
tenthe
approved these changes
Mar 22, 2024
luoluoyuyu
approved these changes
Mar 22, 2024
streampipes-model/src/main/java/org/apache/streampipes/model/schema/EventProperty.java
Outdated
Show resolved
Hide resolved
|
This is really amazing, thank you very much @wyyolo and @RobertIndie. |
RobertIndie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remarks
PR introduces (a) breaking change(s): <yes/no>
PR introduces (a) deprecation(s): <yes/no>