Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test job #3330

Closed
wants to merge 2 commits into from
Closed

Test job #3330

wants to merge 2 commits into from

Conversation

salmanaslam25
Copy link

Purpose

Remarks

PR introduces (a) breaking change(s): <yes/no>

PR introduces (a) deprecation(s): <yes/no>

@github-actions github-actions bot added java Pull requests that update Java code pipeline elements Relates to pipeline elements backend Everything that is related to the StreamPipes backend documentation Everything related to documentation testing Relates to any kind of test (unit test, integration, or E2E test). labels Nov 12, 2024
@tenthe tenthe mentioned this pull request Nov 13, 2024
@tenthe
Copy link
Contributor

tenthe commented Nov 13, 2024

Thanks for implementing this processor!

I have two minor suggestions for improvement:

  • Could we extend it to allow the user to specify how many events should be included in the sum? For example, if the user enters "5," the processor would calculate the sum of the last five events.
  • Also, what do you think about renaming the processor to something like SumProcessor or SummationProcessor to better reflect its function?

Let me know your thoughts!

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Hello there 👋

We noticed that it's been some time since activity occurred on your pull request 🤔. In order to keep things moving forward, we're marking this PR as stale and giving you 7 days to respond before it's automatically closed ⏰.

Please take a moment to review your pull request and make any necessary updates or changes 👨‍💻. If you need more time or have any questions, please don't hesitate to let us know 💬.

Thank you for your contributions to our project, and we look forward to hearing back from you soon 🙏.

@github-actions github-actions bot added the stale Marks pull requests that are classified as `stale` by our bot. label Dec 5, 2024
Copy link
Contributor

Hello there 👋

Unfortunately, we didn't hear back from you regarding your pull request, so we're closing it now. Don't worry, you can always reopen the PR at any time if you wish to continue working on it 🙌.

Please note that the branch associated with this pull request will not be deleted, so you can still access your changes and continue to work on them as needed 💻.

Thank you for your contributions to our project, and we hope to see you again soon!

@github-actions github-actions bot closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Everything that is related to the StreamPipes backend documentation Everything related to documentation java Pull requests that update Java code pipeline elements Relates to pipeline elements stale Marks pull requests that are classified as `stale` by our bot. testing Relates to any kind of test (unit test, integration, or E2E test).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants