Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:#22127 #23489

Closed
wants to merge 1 commit into from
Closed

fix:#22127 #23489

wants to merge 1 commit into from

Conversation

Naveench131
Copy link

@Naveench131 Naveench131 commented Mar 27, 2023 •
edited
Loading

…ds #22127

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Naveench131 Naveench131 marked this pull request as draft March 27, 2023 06:04
@Naveench131 Naveench131 changed the title Import dashboard/assets with overwrite flag does not replace dashboar… fix:#22127 Mar 27, 2023
@Naveench131 Naveench131 marked this pull request as ready for review March 27, 2023 06:06
github-actions[bot]
github-actions bot reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas
Copy link
Member

rusackas commented Feb 9, 2024

@Naveench131 can you please give this PR a rebase, and fill out the PR description with the motivaion/risks/etc? I'll convert this to a draft in the meantime, but please make it "ready for review" when it's ready! Thanks!

@rusackas rusackas marked this pull request as draft February 9, 2024 20:31
@rusackas rusackas mentioned this pull request Feb 9, 2024
Open
3 tasks
@rusackas
Copy link
Member

rusackas commented Dec 9, 2024

Closing this since it hasn't been touched in nearly a year, but happy to reopen it if you ever want to revisit/update it!

@rusackas rusackas closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@TirthParikh27 TirthParikh27 TirthParikh27 approved these changes

Assignees
No one assigned
Labels
review:draft size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Naveench131 @rusackas @TirthParikh27 @john-bodley