-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update messages.json #24744
chore: Update messages.json #24744
Conversation
Mistake in ru translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Rusta12 for the fix.
Actually @michael-s-molina corrected me. You'll have to update the |
Codecov Report
@@ Coverage Diff @@
## master #24744 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 1901 1901
Lines 73927 73927
Branches 8183 8183
=======================================
Hits 50932 50932
Misses 20874 20874
Partials 2121 2121
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things:
• We should indeed edit the .po
files, since the .json
files are generated.
• Are we sure Подитог is correct? I'm hearing that Подытог is the correct spelling.
• If it were Подитог, should we also correct "Расположение столбцов подытогов" and "Расположение строк подытогов"?
Closing this since it's taking the wrong approach (it should edit .po files), and the original contributor doesn't seem to be responding to the change request/question. Thank you for helping to make translations in Superset better... we'll keep working on this, and appreciate your help. |
Mistake in ru translation
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION