Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update messages.json #24744

Closed
wants to merge 1 commit into from
Closed

chore: Update messages.json #24744

wants to merge 1 commit into from

Conversation

Rusta12
Copy link

@Rusta12 Rusta12 commented Jul 19, 2023

Mistake in ru translation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Mistake in ru translation
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rusta12 for the fix.

@john-bodley
Copy link
Member

Actually @michael-s-molina corrected me. You'll have to update the .po file.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #24744 (1bc8bc5) into master (11bb8c3) will not change coverage.
The diff coverage is n/a.

❗ Current head 1bc8bc5 differs from pull request most recent head 657cd47. Consider uploading reports for the commit 657cd47 to get more accurate results

@@           Coverage Diff           @@
##           master   #24744   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files        1901     1901           
  Lines       73927    73927           
  Branches     8183     8183           
=======================================
  Hits        50932    50932           
  Misses      20874    20874           
  Partials     2121     2121           
Flag Coverage Δ
hive 54.15% <ø> (ø)
mysql 79.21% <ø> (ø)
postgres 79.29% <ø> (ø)
presto 54.05% <ø> (ø)
python 83.31% <ø> (ø)
sqlite 77.88% <ø> (ø)
unit 54.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas changed the title Update messages.json Chore: Update messages.json Nov 6, 2023
@rusackas rusackas changed the title Chore: Update messages.json chore: Update messages.json Nov 6, 2023
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things:
• We should indeed edit the .po files, since the .json files are generated.
• Are we sure Подитог is correct? I'm hearing that Подытог is the correct spelling.
• If it were Подитог, should we also correct "Расположение столбцов подытогов" and "Расположение строк подытогов"?

@rusackas
Copy link
Member

rusackas commented Jan 28, 2024

Closing this since it's taking the wrong approach (it should edit .po files), and the original contributor doesn't seem to be responding to the change request/question. Thank you for helping to make translations in Superset better... we'll keep working on this, and appreciate your help.

@rusackas rusackas closed this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants