Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [WIP] Screwing around with improving the UI to add/manage filters... #24951

Closed
wants to merge 1 commit into from

Conversation

rusackas
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #24951 (1c486e2) into master (ec9e9a4) will increase coverage by 0.03%.
Report is 11 commits behind head on master.
The diff coverage is 75.00%.

❗ Current head 1c486e2 differs from pull request most recent head e1b6ee5. Consider uploading reports for the commit e1b6ee5 to get more accurate results

@@            Coverage Diff             @@
##           master   #24951      +/-   ##
==========================================
+ Coverage   69.00%   69.03%   +0.03%     
==========================================
  Files        1906     1905       -1     
  Lines       74133    74127       -6     
  Branches     8208     8208              
==========================================
+ Hits        51153    51176      +23     
+ Misses      20857    20829      -28     
+ Partials     2123     2122       -1     
Flag Coverage Δ
hive 54.18% <25.42%> (+<0.01%) ⬆️
mysql 79.21% <71.18%> (+<0.01%) ⬆️
postgres 79.31% <71.18%> (+<0.01%) ⬆️
presto 54.08% <25.42%> (+<0.01%) ⬆️
python 83.37% <71.18%> (+<0.01%) ⬆️
sqlite 77.89% <71.18%> (+<0.01%) ⬆️
unit 55.06% <25.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <ø> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 69.62% <ø> (ø)
...d/src/SqlLab/components/ShareSqlLabQuery/index.tsx 81.48% <ø> (ø)
...frontend/src/SqlLab/components/SouthPane/index.tsx 79.54% <ø> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx 52.73% <ø> (ø)
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 50.00% <ø> (ø)
superset-frontend/src/components/Chart/Chart.jsx 55.35% <ø> (ø)
...erset-frontend/src/components/Chart/chartAction.js 55.55% <ø> (ø)
...end/src/components/Datasource/DatasourceEditor.jsx 65.63% <ø> (ø)
...tend/src/components/Datasource/DatasourceModal.tsx 75.00% <ø> (ø)
... and 60 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina
Copy link
Member

giphy

@rusackas
Copy link
Member Author

rusackas commented Dec 4, 2024

Closing in favor of #31279

@rusackas rusackas closed this Dec 4, 2024
@rusackas rusackas deleted the split-button-to-add-filters branch December 4, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants