Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs site): Opening up CSP for 3rd party frame content. #27256

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix(docs site): Opening up CSP for 3rd party frame content. #27256

merged 1 commit into from
Feb 26, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Feb 26, 2024 •
edited
Loading

SUMMARY

Opens up the CSP for the Superset website to allow connections for embedded frame content. Allows Preset.io (for Superset Community Newsletters), Google (for the Community Calendar) and for BugHerd (docs issue ticketing).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Feb 26, 2024
@rusackas rusackas changed the title fix(docs site): Openidn CSP for 3rd party frame content. fix(docs site): Opening up CSP for 3rd party frame content. Feb 26, 2024
@rusackas rusackas merged commit ed4b973 into master Feb 26, 2024
31 of 32 checks passed
@rusackas rusackas deleted the csp-changes branch February 26, 2024 20:46
@rusackas rusackas restored the csp-changes branch February 26, 2024 21:21
@rusackas rusackas mentioned this pull request Feb 26, 2024
Merged
9 tasks
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas @sfirke
fix(docs site): Opening up CSP for 3rd party frame content. (apache#2…
e1bcd66 
…7256)
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@rusackas @qleroy
fix(docs site): Opening up CSP for 3rd party frame content. (apache#2…
ac7321f 
…7256)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@rusackas
fix(docs site): Opening up CSP for 3rd party frame content. (apache#2…
433f325 
…7256)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

@geido geido Awaiting requested review from geido

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

@sfirke sfirke Awaiting requested review from sfirke

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rusackas @craig-rueda @mistercrunch