-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hive integration test #27523
fix: Hive integration test #27523
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27523 +/- ##
==========================================
- Coverage 67.46% 67.46% -0.01%
==========================================
Files 1910 1910
Lines 74802 74802
Branches 8345 8345
==========================================
- Hits 50468 50467 -1
- Misses 22283 22284 +1
Partials 2051 2051
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@betodealmeida would you mind to add some test description and summary? |
Hey, this is just a test. I wanted to run the test suite without it stopping on the first error. But for some reason the Hive test didn't run? |
4115237
to
51b4a6d
Compare
4fbcb9b
to
ba0b15b
Compare
@betodealmeida It looks like we'll need to skip more tests.
|
@michael-s-molina huh, you're right... but I'm confused, the tests had passed. I think the problem is with our Hive, I wonder if it was upgraded because we don't have a pinned version in the Docker image? The query is valid, but for some reason it's no longer understanding that |
Also, the tests passed on #27576, which I just rebased. |
@betodealmeida You were able to merge this PR and #27576 only because |
SUMMARY
Skipping the Hive test that is failing with a message that doesn't make sense. It complains about this generated query not being valid due to the
GROUP 1
, even though it is valud:BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION