Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make k8s top item in Installation section #27540

Merged
merged 2 commits into from
Mar 21, 2024
Merged

docs: make k8s top item in Installation section #27540

merged 2 commits into from
Mar 21, 2024

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Mar 16, 2024

Also clarify our stance against using our docker-compose assets in production

tested minikube and provided pointers in the docs

Also clarify our stance against using our docker-compose assets in production
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Mar 16, 2024
@rusackas rusackas requested a review from sfirke March 17, 2024 17:36
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 20, 2024
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only hesitation was the ordering of things. I almost feel like a (more painful) re-org is needed. Rather than Install with {Tool} being the nav options, it feels like we should re-org the content to be Install for {Development/Production} and go into the relevant options on those pages. CC @sfirke

@mistercrunch mistercrunch merged commit e32b1c8 into master Mar 21, 2024
27 of 28 checks passed
@mistercrunch mistercrunch deleted the k8sftw branch March 21, 2024 17:22
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation preset-io size/M 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants