-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(dashboard): dashboard list endpoint returning large and unnecessary data #29121
perf(dashboard): dashboard list endpoint returning large and unnecessary data #29121
Conversation
…rge columns - css, position_json and json_metadata
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29121 +/- ##
===========================================
+ Coverage 60.48% 83.45% +22.96%
===========================================
Files 1931 540 -1391
Lines 76236 39140 -37096
Branches 8568 0 -8568
===========================================
- Hits 46114 32663 -13451
+ Misses 28017 6477 -21540
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@supersetbot org-label |
@supersetbot orglabel |
The challenge with this is it's unclear where and how both Superset* and third party applications are using the payload. At the very least this is a breaking change. * Ideally the Superset frontend would explicitly define which fields it requires so it is evident which fields are actually used by the application. So the non-breaking fix here would be to leave |
SUMMARY
The endpoint of the response list returns unnecessary data - css, position_json, and json_metadata. This fields data is large, and loads the network, but it is not used at the frontend, because they are not needed to display the dashboards list.
In my company, there was a problem with this, because our dashboards are large, and getting list of dashboards was taking 2-3 seconds. As soon as we deleted the return of these fields, it began to load instantly.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
Look at the Content Length
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION