fix: Time-series Line Chart Display unnecessary total #31181
Merged
+45
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
viz:charts:timeseries
justinpark
approved these changes
Nov 27, 2024
sadpandajoe
added
the
v4.1
michael-s-molina
added a commit
that referenced
this pull request
Nov 27, 2024
(cherry picked from commit dbcb473)
sadpandajoe
pushed a commit
that referenced
this pull request
Dec 4, 2024
(cherry picked from commit dbcb473)
betodealmeida
pushed a commit
that referenced
this pull request
Jan 14, 2025
(cherry picked from commit dbcb473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a problem with the new tooltip for timeseries charts where the percentages and totals were always displayed and users didn't have the option to hide them. Having the ability to hide that information is important given that you might have metrics that are not percentage-friendly or you might want to simplify what's displayed.
Fixes #28832
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-11-27.at.10.06.36.mov
TESTING INSTRUCTIONS
Check the video for instructions.
ADDITIONAL INFORMATION