Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax greenlet requirements #31275

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

sadpandajoe
Copy link
Member

SUMMARY

Currently we are pinning greenlet to be 3.0.3, however, there are some instances that greenlet needs to be in a higher version like 3.1.1. Loosening up the requirements here to include the upper bound as needed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@mistercrunch
Copy link
Member

mistercrunch commented Dec 4, 2024

I thought playwright has a hard requirement on 3.0.3 (jut cause they don't know better... submitted a PR to relax their req). The reason why I pinned it is because it throws off supersetbot - it tried to upgrade to 3.1.1 but playwright then complains...

I guess this only affects the development.txt, not the base.txt...

@sadpandajoe
Copy link
Member Author

I thought playwright has a hard requirement on 3.0.3 (jut cause they don't know better... submitted a PR to relax their req). The reason why I pinned it is because it throws off supersetbot - it tried to upgrade to 3.1.1 but playwright then complains...

I guess this only affects the development.txt, not the base.txt...

We currently use 3.1.1 in our system so when we try to do a build without this being relaxed it'll throw an error. So just relaxing it here but keeping the main .txt files untouched.

@mistercrunch
Copy link
Member

actually I have an idea, let me try something

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the pin to base.in, let me know if that unblocks you. If not, we could move to development.in, but both environments would be out-of-sync in regards to their greenlet version, which isn't a problem.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.80%. Comparing base (76d897e) to head (eedfdda).
Report is 1134 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #31275       +/-   ##
===========================================
+ Coverage   60.48%   83.80%   +23.31%     
===========================================
  Files        1931      536     -1395     
  Lines       76236    38943    -37293     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32637    -13477     
+ Misses      28017     6306    -21711     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.78% <ø> (-0.39%) ⬇️
javascript ?
mysql 76.57% <ø> (?)
postgres 76.62% <ø> (?)
presto 53.28% <ø> (-0.53%) ⬇️
python 83.80% <ø> (+20.31%) ⬆️
sqlite 76.09% <ø> (?)
unit 60.87% <ø> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch mistercrunch merged commit 638f82b into apache:master Dec 4, 2024
38 of 39 checks passed
@mistercrunch mistercrunch deleted the joe/loosen-greenlet branch December 4, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants