-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: relax greenlet requirements #31275
Conversation
I thought playwright has a hard requirement on 3.0.3 (jut cause they don't know better... submitted a PR to relax their req). The reason why I pinned it is because it throws off I guess this only affects the |
We currently use 3.1.1 in our system so when we try to do a build without this being relaxed it'll throw an error. So just relaxing it here but keeping the main .txt files untouched. |
actually I have an idea, let me try something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the pin to base.in
, let me know if that unblocks you. If not, we could move to development.in
, but both environments would be out-of-sync in regards to their greenlet version, which isn't a problem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #31275 +/- ##
===========================================
+ Coverage 60.48% 83.80% +23.31%
===========================================
Files 1931 536 -1395
Lines 76236 38943 -37293
Branches 8568 0 -8568
===========================================
- Hits 46114 32637 -13477
+ Misses 28017 6306 -21711
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SUMMARY
Currently we are pinning greenlet to be 3.0.3, however, there are some instances that greenlet needs to be in a higher version like 3.1.1. Loosening up the requirements here to include the upper bound as needed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION