feat: massive theming-related PR

.github/workflows/pre-commit.yml

@@ -41,6 +41,8 @@ jobs:
       - name: pre-commit
         run: |
           set +e  # Don't exit immediately on failure
+          # Skip eslint as it requires `npm ci` and is executed in another job
+          export SKIP=eslint
           pre-commit run --all-files
           if [ $? -ne 0 ] || ! git diff --quiet --exit-code; then
             echo "❌ Pre-commit check failed."

.pre-commit-config.yaml

@@ -52,6 +52,14 @@ repos:
       - id: trailing-whitespace
         exclude: ^.*\.(snap)
         args: ["--markdown-linebreak-ext=md"]
+  - repo: local
+    hooks:
+      - id: eslint
+        name: eslint
+        entry: bash -c 'cd superset-frontend && npm run eslint -- $(echo "$@" | sed "s|superset-frontend/||g")'
+        language: system
+        pass_filenames: true
+        files: \.(js|jsx|ts|tsx)$
   - repo: https://github.com/pre-commit/mirrors-prettier
     rev: v4.0.0-alpha.8 # Use the sha or tag you want to point at
     hooks:

superset-frontend/.eslintrc.js

@@ -210,6 +210,7 @@ module.exports = {
         '*.test.tsx',
         '*.test.js',
         '*.test.jsx',
+        '*src/utils/testUtils*',
         '*.stories.tsx',
         '*.stories.jsx',
         'fixtures.*',
@@ -274,7 +275,7 @@ module.exports = {
         'fixtures.*',
         'cypress-base/cypress/**/*',
         'Stories.tsx',
-        'packages/superset-ui-core/src/style/index.tsx',
+        'packages/superset-ui-core/src/theme/index.tsx',
       ],
       rules: {
         'theme-colors/no-literal-colors': 0,

superset-frontend/.prettierignore

@@ -26,5 +26,7 @@ CHANGELOG/
 *-topo.json
 storybook-static/
 *.snap
+**/*.less
+**/*.less.hbs
 
 /.nx/workspace-data

superset-frontend/.storybook/preview.jsx

@@ -17,8 +17,8 @@
  * under the License.
  */
 import { withJsx } from '@mihkeleidast/storybook-addon-source';
-import { supersetTheme, ThemeProvider } from '@superset-ui/core';
-import { AntdThemeProvider } from '../src/components/AntdThemeProvider';
+import { themeObject } from '@superset-ui/core';
+import { theme } from 'src/preamble';
 import { combineReducers, createStore, applyMiddleware, compose } from 'redux';
 import thunk from 'redux-thunk';
 import { Provider } from 'react-redux';
@@ -34,14 +34,14 @@ const store = createStore(
   compose(applyMiddleware(thunk)),
 );
 
-const themeDecorator = Story => (
-  <ThemeProvider theme={supersetTheme}>
-    <AntdThemeProvider>
+const themeDecorator = Story => {
+  return (
+    <themeObject.SupersetThemeProvider>
       <GlobalStyles />
       <Story />
-    </AntdThemeProvider>
-  </ThemeProvider>
-);
+    </themeObject.SupersetThemeProvider>
+  );
+};
 
 const providerDecorator = Story => (
   <Provider store={store}>

superset-frontend/.storybook/storybook.css

@@ -1,3 +1,2 @@
 body {
-  background: transparent;
 }

superset-frontend/cypress-base/cypress/support/e2e.ts

@@ -19,6 +19,7 @@
 import '@cypress/code-coverage/support';
 import '@applitools/eyes-cypress/commands';
 import failOnConsoleError from 'cypress-fail-on-console-error';
+import { expect } from 'chai';
 
 /* eslint-disable @typescript-eslint/no-explicit-any */
 

superset-frontend/cypress-base/package.json

@@ -20,12 +20,13 @@
     "@cypress/code-coverage": "^3.10.4",
     "@superset-ui/core": "^2.1.0",
     "brace": "^0.11.1",
+    "chai": "^4.5.0",
     "cy-verify-downloads": "^0.2.5",
     "cypress-fail-on-console-error": "^4.0.3",
+    "nanoid": "^5.0.9",
     "querystringify": "^2.2.0",
     "react-dom": "^16.13.0",
-    "rison": "^0.1.1",
-    "nanoid": "^5.0.9"
+    "rison": "^0.1.1"
   },
   "devDependencies": {
     "@types/querystringify": "^2.0.0",

superset-frontend/lerna-debug.log

@@ -0,0 +1,41 @@
+0 silly argv {
+0 silly argv   _: [ 'exec' ],
+0 silly argv   stream: true,
+0 silly argv   concurrency: 10,
+0 silly argv   scope: '@superset-ui/!(demo|generator-superset)\n',
+0 silly argv   args: [
+0 silly argv     '', '', '', '',
+0 silly argv     '', '', ''
+0 silly argv   ],
+0 silly argv   '--': [
+0 silly argv     'babel',
+0 silly argv     '--config-file=../../babel.config.js',
+0 silly argv     'src',
+0 silly argv     '--extensions',
+0 silly argv     '".ts,.tsx,.js,.jsx"',
+0 silly argv     '--copy-files',
+0 silly argv     '--out-dir',
+0 silly argv     'lib'
+0 silly argv   ],
+0 silly argv   lernaVersion: '8.1.8',
+0 silly argv   '$0': 'node_modules/.bin/lerna',
+0 silly argv   cmd: ''
+0 silly argv }
+1 notice cli v8.1.8
+2 verbose packageConfigs Explicit "packages" configuration found in lerna.json. Resolving packages using the configured glob(s): ["packages/*","plugins/*","src/setup/*"]
+3 verbose rootPath /Users/max/code/superset/superset-frontend
+4 error Failed to process project graph. Run "nx reset" to fix this. Please report the issue if you keep seeing it.
+4 error   MultipleProjectsWithSameNameError: The following projects are defined in multiple locations:
+4 error   - storybook-static:
+4 error     - packages/superset-ui-demo/storybook-static
+4 error     - storybook-static
+4 error
+4 error   To fix this, set a unique name for each project in a project.json inside the project's root. If the project does not currently have a project.json, you can create one that contains only a name.
+4 error       at validateAndNormalizeProjectRootMap (/Users/max/code/superset/superset-frontend/node_modules/nx/src/project-graph/utils/project-configuration-utils.js:436:15)
+4 error       at mergeCreateNodesResults (/Users/max/code/superset/superset-frontend/node_modules/nx/src/project-graph/utils/project-configuration-utils.js:322:9)
+4 error       at /Users/max/code/superset/superset-frontend/node_modules/nx/src/project-graph/utils/project-configuration-utils.js:267:85
+4 error       at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
+4 error       at async buildProjectGraphAndSourceMapsWithoutDaemon (/Users/max/code/superset/superset-frontend/node_modules/nx/src/project-graph/project-graph.js:80:31)
+4 error       at async createProjectGraphAndSourceMapsAsync (/Users/max/code/superset/superset-frontend/node_modules/nx/src/project-graph/project-graph.js:208:25)
+4 error       at async createProjectGraphAsync (/Users/max/code/superset/superset-frontend/node_modules/nx/src/project-graph/project-graph.js:198:39)
+4 error       at async detectProjects (/Users/max/code/superset/superset-frontend/node_modules/lerna/dist/index.js:2999:25)