Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Network Errors): Update network errors on filter bars and charts #31811

Merged
merged 22 commits into from
Jan 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
74a6c1c
test(Error): stories
msyavuz Jan 10, 2025
a9f61e5
chore(Error Messages): update filter bar errors
msyavuz Jan 13, 2025
9583cd3
Merge branch 'master' into msyavuz/update-network-errors
msyavuz Jan 13, 2025
1fb351e
feat(NetworkError): add error message component
msyavuz Jan 13, 2025
adf4804
chore(log): remove console log
msyavuz Jan 13, 2025
8d21492
chore(error): localize error
msyavuz Jan 13, 2025
c12852f
chore(ErrorModal): change header color
msyavuz Jan 13, 2025
c1f6800
test(NetworkErrorMessage): add some basic test for network error
msyavuz Jan 13, 2025
60b341e
test(getClientErrorObject): add test for coverage
msyavuz Jan 14, 2025
7c51b38
Merge branch 'master' into msyavuz/update-network-errors
msyavuz Jan 22, 2025
88caace
Merge branch 'master' into msyavuz/update-network-errors
msyavuz Jan 24, 2025
d69c3ba
Merge branch 'master' into msyavuz/update-network-errors
msyavuz Jan 24, 2025
7038026
chore(ErrorMessage): cleanup
msyavuz Jan 24, 2025
d22626f
chore(compact): add compact prop to ErrorWithStackTrace and network e…
msyavuz Jan 24, 2025
d73a6d2
chore(errors): compact on chart
msyavuz Jan 24, 2025
5f7a0ee
chore: remove unneeded changes
msyavuz Jan 24, 2025
19abff9
chore: remove unneeded changes
msyavuz Jan 24, 2025
255c6d4
fix(filter): only filter value error compact
msyavuz Jan 24, 2025
d062294
chore(FilterValue): organize imports
msyavuz Jan 24, 2025
e1ffb38
test(NetworkError): fix and add some tests
msyavuz Jan 27, 2025
1968189
chore(ErrorMessage): remove story covered by another pr
msyavuz Jan 27, 2025
a34ecbf
Update superset-frontend/src/components/ErrorMessage/FrontendNetworkE…
geido Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update superset-frontend/src/components/ErrorMessage/FrontendNetworkE…
…rrorMessage.test.tsx
geido authored Jan 28, 2025
commit a34ecbfebb9c1ba8228a1be24774bddee59ebd01
Original file line number Diff line number Diff line change
@@ -57,7 +57,6 @@ test('should render', () => {

test('should render the error message', () => {
render(<FrontendNetworkErrorMessage {...mockedProps} />, { useRedux: true });
// userEvent.click(screen.getByRole('button'));
expect(screen.getByText('Error message')).toBeInTheDocument();
});