Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various build fixes for clang and rust builds #3095

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Various build fixes for clang and rust builds #3095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/cpp/src/thrift/generate/t_go_generator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ class t_go_generator : public t_generator {

static bool is_pointer_field(t_field* tfield, bool in_container = false);

std::string indent_str() const {
std::string indent_str() const override {
return "\t";
}

Expand Down
2 changes: 1 addition & 1 deletion compiler/cpp/src/thrift/parse/t_function.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class t_function : public t_doc {

std::map<std::string, std::vector<std::string>> annotations_;

void validate() const {
void validate() const override {
get_returntype()->validate();

#ifndef ALLOW_EXCEPTIONS_AS_TYPE
Expand Down
2 changes: 1 addition & 1 deletion compiler/cpp/src/thrift/parse/t_list.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class t_list : public t_container {

bool is_list() const override { return true; }

void validate() const {
void validate() const override {
#ifndef ALLOW_EXCEPTIONS_AS_TYPE
if( get_elem_type()->get_true_type()->is_xception()) {
failure("exception type \"%s\" cannot be used inside a list", get_elem_type()->get_name().c_str());
Expand Down
2 changes: 1 addition & 1 deletion compiler/cpp/src/thrift/parse/t_map.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class t_map : public t_container {

bool is_map() const override { return true; }

void validate() const {
void validate() const override {
#ifndef ALLOW_EXCEPTIONS_AS_TYPE
if( get_key_type()->get_true_type()->is_xception()) {
failure("exception type \"%s\" cannot be used inside a map", get_key_type()->get_name().c_str());
Expand Down
2 changes: 1 addition & 1 deletion compiler/cpp/src/thrift/parse/t_set.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class t_set : public t_container {

bool is_set() const override { return true; }

void validate() const {
void validate() const override {
#ifndef ALLOW_EXCEPTIONS_AS_TYPE
if( get_elem_type()->get_true_type()->is_xception()) {
failure("exception type \"%s\" cannot be used inside a set", get_elem_type()->get_name().c_str());
Expand Down
2 changes: 1 addition & 1 deletion compiler/cpp/src/thrift/parse/t_struct.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class t_struct : public t_type {
return nullptr;
}

void validate() const {
void validate() const override {
std::string what = "struct";
if( is_union()) {
what = "union";
Expand Down
2 changes: 1 addition & 1 deletion tutorial/rs/src/bin/tutorial_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ fn new_client(

// open the underlying TCP stream
println!("connecting to tutorial server on {}:{}", host, port);
c.open(&format!("{}:{}", host, port))?;
c.open(format!("{}:{}", host, port))?;

// clone the TCP channel into two halves, one which
// we'll use for reading, the other for writing
Expand Down