[TINKERPOP-2489] Server doesn't start if folder has spaces #3020
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #3020 +/- ##
=============================================
+ Coverage 76.14% 76.36% +0.22%
- Complexity 13152 13236 +84
=============================================
Files 1084 1061 -23
Lines 65160 61579 -3581
Branches 7285 7342 +57
=============================================
- Hits 49616 47026 -2590
+ Misses 12839 12033 -806
+ Partials 2705 2520 -185 ☔ View full report in Codecov by Sentry. |
| @@ -166,7 +166,7 @@ start() { | |||
| exit 1 | |||
| fi | |||
|
|
|||
| $JAVA -Dlogback.configurationFile=$LOGBACK_CONF $JAVA_OPTIONS -cp $CLASSPATH $GREMLIN_SERVER_CMD "$GREMLIN_YAML" >> "$LOG_FILE" 2>&1 & | |||
| $JAVA -Dlogback.configurationFile="$LOGBACK_CONF" $JAVA_OPTIONS -cp "$CLASSPATH" "$GREMLIN_SERVER_CMD" "$GREMLIN_YAML" >> "$LOG_FILE" 2>&1 & | |||
There was a problem hiding this comment.
Should JAVA_OPTIONS also be quoted?
There was a problem hiding this comment.
JAVA_OPTIONS being quoted threw an exception regarding memory.
|
VOTE +1 |
| @@ -96,7 +96,7 @@ fi | |||
|
|
|||
| # Build Java CLASSPATH | |||
| CP="$GREMLIN_HOME/conf/" | |||
| CP="$CP":$( echo $GREMLIN_HOME/lib/*.jar . | sed 's/ /:/g') | |||
| CP="$CP":$( find "$GREMLIN_HOME/lib" -name "*.jar" -print | tr '\n' ':' ) | |||
There was a problem hiding this comment.
There's a slight difference in the output of these 2 commands.
echo $GREMLIN_HOME/lib/*.jar . | sed 's/ /:/g' produces something like this:
path_to_x.jar:path_to_y.jar:path_to_z.jar:.
whereas find "$GREMLIN_HOME/lib" -name "*.jar" -print | tr '\n' ':' produces something like this:
path_to_x.jar:path_to_y.jar:path_to_z.jar:
The new classpath is missing the current directory (.).
Also just a small nit, the new classpath is ending with a trailing :, I don't think this causes any issues but it is a bit atypical.
TINKERPOP: https://issues.apache.org/jira/browse/TINKERPOP-2489
Bug: If working directory contained spaces running gremlin-server.sh resulted in file not found exception
Fix: added quotations to appropriate areas and fixed code that replaced spaces with colons to not change any spaces directory names.