TINKERPOP-3130 Allowed discard() as anonymous and chained #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spmallette
changed the title
spmallette
force-pushed
the
TINKERPOP-3130-master
branch
from
0479f54 to
65337de
Compare
andreachild
reviewed
Feb 7, 2025
| @@ -1469,6 +1473,10 @@ def min_(cls, *args): | |||
| def none(cls, *args): | |||
| return cls.graph_traversal(None, None, GremlinLang()).none(*args) | |||
|
|
|||
| @classmethod | |||
| def none(cls, *args): | |||
There was a problem hiding this comment.
None is already defined above
There was a problem hiding this comment.
This looks like a copy error that should be removed, it's also adding Bytecode().
There was a problem hiding this comment.
missed that merge issue during the cherry-pick - good catch.
andreachild
reviewed
Feb 7, 2025
|
|
||
| Scenario: g_V_discard_fold_none |
There was a problem hiding this comment.
Should this be named discard_fold_discard?
andreachild
reviewed
Feb 7, 2025
| When iterated to list | ||
| Then the result should be empty | ||
|
|
||
| Scenario: g_V_discard_none |
There was a problem hiding this comment.
Should this be discard_discard?
|
VOTE +1, pending closure of comments made by other reviewers. |
xiazcy
reviewed
Feb 7, 2025
| @@ -470,6 +470,14 @@ public static GraphTraversal<object, object> Difference(object differenceObject) | |||
| return new GraphTraversal<object, object>().Difference(differenceObject); | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Spawns a <see cref="GraphTraversal{SType, EType}" /> and adds the none step to that traversal. | |||
There was a problem hiding this comment.
nit on docs
Suggested change
| /// Spawns a <see cref="GraphTraversal{SType, EType}" /> and adds the none step to that traversal. | |
| /// Spawns a <see cref="GraphTraversal{SType, EType}" /> and adds the discard step to that traversal. |
|
VOTE +1 pending comment resolution. |
spmallette
force-pushed
the
TINKERPOP-3130-master
branch
from
65337de to
6a52c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3130
Should be a non-breaking change, in that it just expands what
discard()can do to be more consistent in its usage.VOTE +1