Record the amount of early data correctly #11883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The amount was incremented only after TLS handshake is completed
|
[approve ci] |
1 similar comment
|
[approve ci] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two bugs around early data.
The first commit fixes a bug in autest tls_0rtt_server (more specifically, the test client, test-0rtt-s_client). The test does not use ALPN to use H2 on TLS a TLS connection (protocol violation). The violation was found on #11881 (the test fails with the fix on #11881).
The second commit fixes the other bug in SSLNetVC. It increments the total amount of early data received only after TLS handshake is completed. The first commit revealed this bug because it slightly changes the timing of read operations.