Return false when datatype is not comparable for InFilter.

apache · Jul 23, 2024 · b81f754 · b81f754
1 parent 1dbcdef
commit b81f754
Showing 1 changed file with 31 additions and 18 deletions.
diff --git a/java/tsfile/src/main/java/org/apache/tsfile/read/filter/operator/ValueFilterOperators.java b/java/tsfile/src/main/java/org/apache/tsfile/read/filter/operator/ValueFilterOperators.java
@@ -790,19 +790,22 @@ public boolean canSkip(IMetadata metadata) {
       }
 
       if (statistics.isPresent()) {
-        T valuesMin = (T) statistics.get().getMinValue();
-        T valuesMax = (T) statistics.get().getMaxValue();
-        // All values are same
-        if (valuesMin.compareTo(valuesMax) == 0) {
-          return !candidates.contains(valuesMin);
-        } else {
-          if (candidates.size() != 0) {
-            // All values are less than min, or greater than max
-            if (candidatesMin.compareTo(valuesMax) > 0) {
-              return true;
-            }
-            if (candidatesMax.compareTo(valuesMin) < 0) {
-              return true;
+        Statistics<? extends Serializable> stat = statistics.get();
+        if (!statisticsNotAvailable(stat)) {
+          T valuesMin = (T) stat.getMinValue();
+          T valuesMax = (T) stat.getMaxValue();
+          // All values are same
+          if (valuesMin.compareTo(valuesMax) == 0) {
+            return !candidates.contains(valuesMin);
+          } else {
+            if (candidates.size() != 0) {
+              // All values are less than min, or greater than max
+              if (candidatesMin.compareTo(valuesMax) > 0) {
+                return true;
+              }
+              if (candidatesMax.compareTo(valuesMin) < 0) {
+                return true;
+              }
             }
           }
         }
@@ -829,11 +832,14 @@ public boolean allSatisfy(IMetadata metadata) {
 
       // All values are same
       if (statistics.isPresent()) {
-        T valuesMin = (T) statistics.get().getMinValue();
-        T valuesMax = (T) statistics.get().getMaxValue();
-        // All values are same
-        if (valuesMin.compareTo(valuesMax) == 0) {
-          return candidates.contains(valuesMin);
+        Statistics<? extends Serializable> stat = statistics.get();
+        if (!statisticsNotAvailable(stat)) {
+          T valuesMin = (T) stat.getMinValue();
+          T valuesMax = (T) stat.getMaxValue();
+          // All values are same
+          if (valuesMin.compareTo(valuesMax) == 0) {
+            return candidates.contains(valuesMin);
+          }
         }
       }
 
@@ -858,6 +864,13 @@ public OperatorType getOperatorType() {
     private boolean isAllNulls(Statistics<? extends Serializable> statistics) {
       return statistics.getCount() == 0;
     }
+
+    private static boolean statisticsNotAvailable(Statistics<?> statistics) {
+      return statistics.getType() == TSDataType.TEXT
+          || statistics.getType() == TSDataType.BOOLEAN
+          || statistics.getType() == TSDataType.BLOB
+          || statistics.isEmpty();
+    }
   }
 
   public static final class ValueNotIn<T extends Comparable<T>> extends ValueColumnSetFilter<T> {