[CPP] Support alternative gtest url #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
761417898
commented
Jul 20, 2024
761417898
commented
- Support alternative GTEST URL for users in China
- Unit tests will be skipped if the download fails
HTHou
reviewed
Jul 22, 2024
cpp/test/CMakeLists.txt
Outdated
Comment on lines
22
to
24
| "https://github.com/google/googletest/archive/refs/tags/v1.12.0.zip" | ||
| "https://hub.nuaa.cf/google/googletest/archive/refs/tags/v1.12.0.zip" | ||
| "https://hub.yzuu.cf/google/googletest/archive/refs/tags/v1.12.0.zip" |
There was a problem hiding this comment.
I see the gtest has released v1.12.1 that also supports C++ 11, should we consider upgrading it?
There was a problem hiding this comment.
OK, I will upgrade the version to v1.12.1. Both v1.12.0 and v1.12.1 are stated to be the latest versions that support C++11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.