Binary allocator #339
Closed
Binary allocator #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +70,7 @@ public int compareTo(Binary other) { | |||
| } | |||
|
|
|||
| // avoid overflow | |||
| private char getChar(byte[] val, int index) { | |||
| protected char getChar(byte[] val, int index) { | |||
There was a problem hiding this comment.
看起来 tsfile 包里面没有用到这个 protect 属性的？是在 iotdb 包里面吗？我没在 MrQuansy/iotdb@f99caa1 搜到用到这个的
| @@ -125,4 +149,12 @@ public void setValues(byte[] values) { | |||
| public long ramBytesUsed() { | |||
| return INSTANCE_SIZE + sizeOf(values); | |||
| } | |||
|
|
|||
| public long ramShallowBytesUsed() { | |||
| public Binary toBinary() { | ||
| return binary; | ||
| @Override | ||
| public long ramShallowBytesUsed() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.