Draft PR for Jakarta ee10 jdk17

[eduarddrenth]

For discussion on the diff, see https://issues.apache.org/jira/browse/VELTOOLS-202

[michael-o]

Can you figure out frim with JSP API version this is not required anymore?

[eduarddrenth]

I'll try

[eduarddrenth]

Since 4.0.0, 3.1.1 still has it. See also https://projects.eclipse.org/projects/ee4j.jsp/releases/4.0.0

[michael-o]

Good, thanks. @arkanovicz I wonder whether we should raise to Servlet 4.0 before that.

[michael-o]

Given the comments at class level, I wonder whether we still need this file...

[michael-o]

Good, thanks. @arkanovicz I wonder whether we should raise to Servlet 4.0 before that.

[michael-o]

@arkanovicz I see at least two classes which have been copied from Tomcat. I wonder whether they are still required these days...

[arkanovicz]

@arkanovicz I see at least two classes which have been copied from Tomcat. I wonder whether they are still required these days...

I don't really maintain the jsp module. I released it unchanged last time, but if nobody can help maintain it, we can deprecate it.

[michael-o]

@arkanovicz I see at least two classes which have been copied from Tomcat. I wonder whether they are still required these days...

I don't really maintain the jsp module. I released it unchanged last time, but if nobody can help maintain it, we can deprecate it.

That would mean that the JSP tags are dead, aren't they?

[arkanovicz]

@arkanovicz I see at least two classes which have been copied from Tomcat. I wonder whether they are still required these days...

I don't really maintain the jsp module. I released it unchanged last time, but if nobody can help maintain it, we can deprecate it.

That would mean that the JSP tags are dead, aren't they?

I released it as is last time because I've been told that jsp hadn't change, so there was no real reason for the module not to be functional. But I never used jsp, never will, and I do not feel very concerned by its fate. Maybe ask the mailing list?

[michael-o]

@arkanovicz I see at least two classes which have been copied from Tomcat. I wonder whether they are still required these days...

I don't really maintain the jsp module. I released it unchanged last time, but if nobody can help maintain it, we can deprecate it.

That would mean that the JSP tags are dead, aren't they?

I released it as is last time because I've been told that jsp hadn't change, so there was no real reason for the module not to be functional. But I never used jsp, never will, and I do not feel very concerned by its fate. Maybe ask the mailing list?

Yes, let's do so.

[michael-o]

@eduarddrenth First of all, thank you for the good cooperation. I already see a few points I can cherry-pick and improve the current code on main, but first I need to take care of velocity master as a prep. Please stay tuned.

[eduarddrenth]

Thanks also, I enjoyed to play a small part in making velocity available to application servers for jakarta EE 10. I'll keep an eye open.

[michael-o]

Why did you close? This is viable code.

[eduarddrenth]

Why did you close? This is viable code.

I thought you did not need it anymore. Is the process?

• prepare velocity master
• merge changes into my fork
• adapt or resubmit jakarta PR
• merge PR
• decide how to release jakarta version and release it

[michael-o]

Why did you close? This is viable code.

I thought you did not need it anymore. Is the process?

* prepare velocity master

* merge changes into my fork

* adapt or resubmit jakarta PR

* merge PR

* decide how to release jakarta version and release it

You misunderstood. I need to keep it open for visibile and future changes.

[michael-o]

Factored out a bit #21

[eduarddrenth]

At some point in the near future I need to decide how to include velocity deps in my jakarta apps. Either I wait for a jakarta release from the apache team, or I decide to keep my fork up-to-date and release to maven central myself. I prefer the first, but when will this release be?

[michael-o]

At some point in the near future I need to decide how to include velocity deps in my jakarta apps. Either I wait for a jakarta release from the apache team, or I decide to keep my fork up-to-date and release to maven central myself. I prefer the first, but when will this release be?

I have expressed my opinion in this regard in the other PR already: #15 (comment)