[YUNIKORN-3000] Add support for setting GOGC / GOMEMLIMIT in Helm chart #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added helm variables to allow customizing GOGC / GOMEMLIMIT for YuniKorn components. GOGC is set to 100 (the default) for all services. GOMEMLIMIT is configured by default to 200MiB for the web and admission controller containers, and 1536MiB for the scheduler. This provides ample headroom to avoid encountering OOMKilled events in Kubernetes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Added helm variables to allow customizing GOGC / GOMEMLIMIT for YuniKorn components. GOGC is set to 100 (the default) for all services. GOMEMLIMIT is configured by default to 200MiB for the web and admission controller containers, and 1536MiB for the scheduler. This provides ample headroom to avoid encountering OOMKilled events in Kubernetes.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-3000
How should this be tested?
Screenshots (if appropriate)
Admission Controller Pod:
Scheduler Pod:
Questions: