Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2460] Unify ask and allocation APIs #140

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

What is this PR for?

Remove ask-specific APIs and use UpdateAllocation for all communication.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2460

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Remove ask-specific APIs and use UpdateAllocation for all communication.
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting change only, did not see any other issues

scheduler-interface-spec.md Show resolved Hide resolved
@wilfred-s
Copy link
Contributor

BTW this PR should move to the ready state. As long as we do not update the core and k8shim reference in the go.mod file it will not be picked up.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craigcondit craigcondit marked this pull request as ready for review August 15, 2024 14:25
@craigcondit craigcondit deleted the YUNIKORN-2460 branch August 15, 2024 14:27
@wilfred-s
Copy link
Contributor

The formatting is changed because the old two graphs are combined into one new one.

Filed YUNIKORN-2809 to fix the formatting of the node state transition as it currently does not display as it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants