Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GT-96 Django monitoring app #15

Merged
merged 53 commits into from
Feb 28, 2024
Merged

GT-96 Django monitoring app #15

merged 53 commits into from
Feb 28, 2024

Conversation

Letizia97
Copy link
Contributor

Features:

  • improvements for Python 3 compatibility
  • sync table
  • sync table with submithosts

@tofu-rocketry
Copy link
Member

Can you fix the 'style' category issues that Codeclimate has raised? Don't worry about the other categories of issue for now though, other than the 'clarity' category about the if statement.

For line length, follow the PEP 8 guidance for longer lines (I need to change the linting to use this setting though):

Some teams strongly prefer a longer line length. For code maintained exclusively or primarily by a team that can reach agreement on this issue, it is okay to increase the line length limit up to 99 characters, provided that comments and docstrings are still wrapped at 72 characters.

@Letizia97 Letizia97 force-pushed the django_experiments_3 branch 7 times, most recently from 973b41b to 28667a0 Compare February 7, 2023 13:21
@tofu-rocketry tofu-rocketry changed the title Django monitoring app GT-96 Django monitoring app Feb 7, 2023
@tofu-rocketry tofu-rocketry self-assigned this Feb 7, 2023
@tofu-rocketry tofu-rocketry changed the title GT-96 Django monitoring app Django monitoring app Feb 7, 2023
@tofu-rocketry tofu-rocketry changed the title Django monitoring app GT-96 Django monitoring app Feb 7, 2023
@Letizia97 Letizia97 mentioned this pull request Feb 28, 2023
Merged
gregcorbett
gregcorbett reviewed Mar 13, 2023
View reviewed changes
monitoring/publishing/serializers.py
Comment on lines +44 to +48
# Sitename substitutes pk
lookup_field = 'SiteName'
extra_kwargs = {
'url': {'lookup_field': 'SiteName'}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do? Are both lookup_field and extra_kwargs needed?

@gregcorbett
Copy link
Member

Looks good, a few questions - see above. I can see codeclimate raised 47 issues, but can't see what they are 😢

Letizia97 and others added 20 commits January 24, 2024 16:01
@Letizia97 @tofu-rocketry
Remove unnecessary blank lines.
581cd04
@Letizia97 @tofu-rocketry
Move import to the top of file.
2d3f961
@Letizia97 @tofu-rocketry
Rearrange/refactor imports to shorten lines.
58af9a8
@Letizia97 @tofu-rocketry
Rearrange/refactor serialiser fields to shorten lines.
0cc3f30
@Letizia97 @tofu-rocketry
Rearrange/refactor urlpatterns to shorten lines.
0933fb8
@Letizia97 @tofu-rocketry
Rearrange dicts to shorten lines.
6982316
@Letizia97 @tofu-rocketry
Refactor parts to create/fill dicts, to reduce duplication and file l…
c10e9e9 
…ength.
@Letizia97 @tofu-rocketry
Bring functions outside class to avoid duplication.
d8c409e
@Letizia97 @tofu-rocketry
Refactor to reduce line length.
0761c70
@Letizia97 @tofu-rocketry
Merge if statements to ensure clarity.
2ac7462
@Letizia97 @tofu-rocketry
Rearrange SQL queries to reduce line length.
22d1383
@Letizia97 @tofu-rocketry
Create separate function for sync_status to reduce duplication.
5ca8c66
@Letizia97 @tofu-rocketry
Create separate function foupdating stdout and returncode.
5799dbb
@Letizia97 @tofu-rocketry
Refactor to reduce length of lines.
12b166e
@tofu-rocketry
Add missing objects that weren't created/imported
b03791d
@tofu-rocketry
Correct reference to grid database from settings
ee92a54
@tofu-rocketry
Automate venv activation
3b3453d 
Putting venv activation in the wsgi file means that Apache can invoke
the venv and it doesn't need to be done manually.
@tofu-rocketry
Tidy up settings
9d647a6
@tofu-rocketry
Change sync status to match old pages
bd77d79
@tofu-rocketry
Revert changes to availability app urls
4b2902c
@tofu-rocketry tofu-rocketry added the enhancement New feature or request label Feb 28, 2024
@tofu-rocketry tofu-rocketry mentioned this pull request Feb 28, 2024
Open
@tofu-rocketry tofu-rocketry merged commit 03f8758 into apel:dev Feb 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregcorbett gregcorbett gregcorbett left review comments

@tofu-rocketry tofu-rocketry tofu-rocketry approved these changes

Assignees

@tofu-rocketry tofu-rocketry

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Letizia97 @tofu-rocketry @gregcorbett