Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to improve the naming convention for rpm and deb builds #384

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Sae126V
Copy link
Member

@Sae126V Sae126V commented Dec 6, 2024

  • Updated the code to include python(Major+minor) for the naming of builds generated using the FPM script.

@Sae126V Sae126V requested a review from a team as a code owner December 6, 2024 15:47
@tofu-rocketry
Copy link
Member

So the idea was to make it easy to tell what Python version we need for the sake of the site-packages directory location. I've been down bit of a rabbit hole trying to figure if there's a better way than just naming the RPM - it feels like there should be as we don't really care what version we're on beyond it being Python 3 probably. This would suggest that we should actually package the program to install in a non-python location.

In terms of this specific change, it doesn't quite match the usual rpm schemes I can find. They usually use python3.X- as a prefix. And we would need to add an Obsoletes and Provides to enable a smooth transition. https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages

However, I need to have a think about the overall effect we want to achieve, so will put this on hold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants