Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared library for parsing stream format #188

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

mr-martian
Copy link
Contributor

This is relevant to apertium/apertium#213 and probably other things

@mr-martian
Copy link
Contributor Author

Tests pass, though I haven't applied it to any real data yet

@unhammer
Copy link
Member

unhammer commented Oct 8, 2024

seems like tests in nno-nob pass with it (I built&installed lttoolbox and apertium with --prefix=$HOME/PREFIX/lttoolbox and did export PATH=$HOME/PREFIX/lttoolbox/bin:$PATH && cd apertium-nno-nob && make -j test)

@unhammer
Copy link
Member

Was there a reason for not merging this yet?

I just tried this with nob-nno on a corpus, no diffs on 2k lines.

@unhammer
Copy link
Member

After installing lttoolbox and apertium to $HOME/PREFIX/lttoolbox, I tried

$ cat test/fra-oci*input.txt | apertium fra-oci >/tmp/old && cat test/oci-fra*input.txt | apertium oci-fra >>/tmp/old;

$ export LD_LIBRARY_PATH=$HOME/PREFIX/lttoolbox/lib

$ export PATH=$HOME/PREFIX/lttoolbox/bin:$PATH

$ cat test/fra-oci*input.txt | apertium -d /usr/share/apertium/ fra-oci >/tmp/new && cat test/oci-fra*input.txt | apertium -d /usr/share/apertium/ oci-fra >>/tmp/new
# (lots of stderr this time)

$ diff -s /tmp/{old,new}
Files /tmp/old and /tmp/new are identical

When I comment out the stderr stuff, speed seems the same as well.

@mr-martian mr-martian merged commit 147f4c9 into main Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants