Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix volume units "goutte" and "cac" #233

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

ycattan
Copy link
Contributor

@ycattan ycattan commented Dec 7, 2023

According to wikipedia:

  • 1 cac = 5 ml
  • 1 goutte = 5e-2 ml
  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c918130) 96.58% compared to head (058fb16) 96.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         254      254           
  Lines        8356     8356           
=======================================
  Hits         8071     8071           
  Misses        285      285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@percevalw percevalw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks !

@percevalw percevalw merged commit d43fbd9 into aphp:master Dec 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants