Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support missing torch with spark and multiprocessing backends #244

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

percevalw
Copy link
Member

@percevalw percevalw commented Jan 4, 2024

Description

Fixes #243

  • one of the errors came from torch being imported without handling import errors (torch is an optional dependency)
  • the second main error came from the from .registry import registry in edsnlp/core.py, preventing python from programmatically importing the classes from edsnlp/core/registry.py. Because of this, dill tryed to serialize the entire registry module, and some other modules from edsnlp, causing various serialization issues.

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb08237) 96.70% compared to head (2da3cc3) 96.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   96.70%   96.70%           
=======================================
  Files         255      255           
  Lines        8369     8372    +3     
=======================================
+ Hits         8093     8096    +3     
  Misses        276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percevalw percevalw force-pushed the fix-missing-torch branch 3 times, most recently from 56c184b to cdae327 Compare January 5, 2024 11:39
@percevalw percevalw merged commit bd0c388 into master Jan 5, 2024
10 checks passed
@percevalw percevalw deleted the fix-missing-torch branch January 5, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing torch cause multiprocessing backend error
1 participant