Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML inference fixes & features #251

Merged
merged 10 commits into from
Jan 18, 2024
Merged

ML inference fixes & features #251

merged 10 commits into from
Jan 18, 2024

Conversation

percevalw
Copy link
Member

Description

Added

  • Support loading model from package name (e.g., edsnlp.load("eds_pseudo_aphp"))

Fixed

  • Support doc -> list converters with parquet files writer
  • Fixed some OOM errors when writing many outputs to parquet files
  • Both edsnlp & spacy factories are now listed when a factory lookup fails
  • Fixed some GPU OOM errors with the eds.transformer pipe when processing really long documents

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (518df4c) 96.70% compared to head (999fcdc) 96.76%.

Files Patch % Lines
edsnlp/extensions.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   96.70%   96.76%   +0.05%     
==========================================
  Files         255      255              
  Lines        8379     8433      +54     
==========================================
+ Hits         8103     8160      +57     
+ Misses        276      273       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percevalw percevalw merged commit 035a344 into master Jan 18, 2024
10 checks passed
@percevalw percevalw deleted the ml-inference branch January 18, 2024 21:02
@percevalw percevalw restored the ml-inference branch January 18, 2024 21:02
@percevalw percevalw deleted the ml-inference branch November 14, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant