Fix filter eager loading & merge #1449 + test #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyerbaptiste
approved these changes
Nov 2, 2017
dunglas
approved these changes
Nov 3, 2017
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…ding Fix filter eager loading & merge api-platform#1449 + test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is a fix on
FilterEagerLoadingExtensionwith composite identifiers when one of the composite identifier is not an association. I also improved the testability ofEagerLoadingTraitby usingClassMetadataInfomethods instead of public properties (easier to prophesize).Merges #1313 - LIMIT and ORDER BY on a column from a fetch joined to-many as… #1449 + add a test + improve comment