feat(serializer): check in child classes attribute's groups for serialization #6382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoine-nedelec
force-pushed
the
feat/normalize-child-class-attribute-groups
branch
3 times, most recently
from
723f297
to
ead9c6c
Compare
antoine-nedelec
changed the title
antoine-nedelec
force-pushed
the
feat/normalize-child-class-attribute-groups
branch
4 times, most recently
from
c5572f7
to
c7c625f
Compare
antoine-nedelec
changed the title
antoine-nedelec
force-pushed
the
feat/normalize-child-class-attribute-groups
branch
from
c7c625f
to
01d4c0f
Compare
antoine-nedelec
changed the title
soyuka
reviewed
May 24, 2024
| @@ -203,6 +204,18 @@ private function getClassSerializerGroups(string $class): array | |||
| $groups[] = $serializerAttributeMetadata->getGroups(); | |||
| } | |||
|
|
|||
| if (true === $this->normalizeChildClassAttributeGroups) { | |||
| foreach ($serializerClassMetadata->getReflectionClass()->getAttributes() as $reflectionAttribute) { | |||
| if (DiscriminatorMap::class !== $reflectionAttribute->getName()) { | |||
There was a problem hiding this comment.
is discriminatorMap an attribute of the serializer? not sure I understand how this works.
soyuka
reviewed
May 24, 2024
| @@ -17,6 +17,7 @@ | |||
| use ApiPlatform\Metadata\Exception\ResourceClassNotFoundException; | |||
| use ApiPlatform\Metadata\ResourceClassResolverInterface; | |||
| use ApiPlatform\Metadata\Util\ResourceClassInfoTrait; | |||
| use Doctrine\ORM\Mapping\DiscriminatorMap; | |||
There was a problem hiding this comment.
not a huge fan of using doctrine in this file, it'd be best inside DoctrineOrmPropertyMetadataFactory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue created:
Self contained repository for reproduction:
Overall logic:
Remarks: