feat(swagger-ui): persist authorization #6877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViPErCZ
changed the title
|
I second this change. It's much better to have the ability to persist authorization rather than having to type in the PKCE client ID each time. |
|
can you target the 4.1 or main branch? |
only 4.1 version (branch) is OK for me ❤️ |
|
@soyuka Do I need to do anything else? |
|
I changed the target branch to 4.1 but this needs a rebase, also it looks like test failures are related, feel free to ping me on slack if you've trouble running tests. |
|
@soyuka I fixed the merge conflicts and tests (my unit tests are also running locally), but some Laravel tests are still crashing. Can you please take a look? Thank you. |
soyuka
requested changes
Jan 16, 2025
src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
soyuka
reviewed
Jan 17, 2025
|
@soyuka thanks... perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FTR] add Swagger UI config directive: persistAuthorization