Attempt to replace HH Node with Anvil to allow upgrade to Node 20 #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquarat
changed the title
aquarat
commented
Sep 20, 2024
| @@ -34,7 +34,7 @@ | |||
| "@types/mocha": "^10.0.6", | |||
| "chai": "^4.4.1", | |||
| "ethereum-waffle": "^4.0.10", | |||
| "hardhat": "^2.19.5", | |||
| "hardhat": "^2.23.0-dev.3", | |||
aquarat
commented
Sep 20, 2024
| @@ -6,7 +6,7 @@ describe('buildingRequest', () => { | |||
| const options = fixtures.buildRequestOptions(); | |||
| const res = build.buildRequest(options); | |||
| expect(res).toEqual({ | |||
| baseUrl: 'http://localhost:5000', | |||
| baseUrl: 'http://localhost:5005', | |||
There was a problem hiding this comment.
Mac OS runs an Airdrop service on this port.
aquarat
commented
Sep 20, 2024
| @@ -75,7 +75,7 @@ describe('SDK', () => { | |||
|
|
|||
| it('uses transaction overrides', async () => { | |||
| await expect(sdk.sponsorRequester(wallet.address, { gasLimit: 1 })).rejects.toThrow( | |||
| 'Transaction requires at least 21572 gas but got 1' | |||
| expect.objectContaining({name: expect.stringContaining('Error'), message: expect.stringContaining('gas')}) | |||
There was a problem hiding this comment.
Anvil returns a different error message for gas compared to HH Node.
aquarat
commented
Sep 20, 2024
| @@ -103,6 +104,11 @@ const processBlockData = async ( | |||
| } | |||
| }; | |||
|
|
|||
| const resetAnvil = async () => { | |||
| spawn("bash", ["-c", 'killall anvil;']); | |||
| await new Promise(f => setTimeout(f, 1000)); | |||
There was a problem hiding this comment.
Ideally starting and stopping Anvil could be managed in code or handled more intelligently.
A more comprehensive approach can be found here: https://github.com/api3dao/oev-searcher-poc/blob/main/src/simulation.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.