Implement various minor fixes #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreogle
approved these changes
Nov 28, 2023
Siegrift
force-pushed
the
minor-fixes
branch
from
33dc2de to
e143b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
@andreogle found various issues when running signed API and Airseeker locally. Specifically:
DEV_SERVER_PORTnot workingDEV_SERVER_PORTis not set to 8090 by default (pusher expects signed API on this port)Unauthorized Airnode addressmessage.allowedAirnodesset to random Airnode instead of the address of the pusher configured for development (with fixed mnemonic).These are all implemented, and I've slightly changed the function for generating error response.
There was another point, whether pusher needs to use both
.envand.secrets.envbut there is a conceptual difference between those so I'm leaving that in place.