Remove port expose from docker #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Sep 19, 2023
| @@ -26,5 +26,4 @@ RUN npm install -g pnpm | |||
| # Only install dependencies for production (ignore "devDependecies" section in package.json). | |||
| RUN pnpm install --prod | |||
|
|
|||
| EXPOSE 3000 | |||
There was a problem hiding this comment.
Btw. the default values inside the docker-compose need to be applied everywhere.
andreogle
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to expose docker port, since that is mainly for documentation purposes and we allow configuring the port number so I'd even say it's confusing.