Support caching on AWS CloudFront #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdrhn9 LMK if you see some issues with this, but I think it's OK. |
bdrhn9
approved these changes
Jan 18, 2024
andreogle
approved these changes
Jan 18, 2024
Siegrift
force-pushed
the
allow-secrets
branch
from
52ab963 to
b4ad247
Compare
Yeah, thanks :) Too many cloudXyz at this point for my brain. |
Siegrift
changed the title
Siegrift
force-pushed
the
cache-headers
branch
from
5302078 to
0d84b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193
AWS CloudFront does not support caching based on custom header nor does recognize
cdn-cache-control. The original issue mentioned making the cache headers more generic, but I don't think it's necessary. We can use both the standardcache-controlfor browser-cache (which is recognized by CloudFront) and thecdn-cache-control.The PR also removes these headers from POST response (which does not make sense).