Implement e2e test flow, fix small bugs #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Oct 2, 2023
| @@ -14,7 +14,7 @@ export const startServer = (config: Config) => { | |||
| const result = await batchInsertData(req.body); | |||
| res.status(result.statusCode).header(result.headers).send(result.body); | |||
|
|
|||
| logger.info('Responded to request "POST /"', result); | |||
| logger.debug('Responded to request "POST /"', result); | |||
There was a problem hiding this comment.
This was too spammy. Note, that I still left the receive log as INFO level.
Siegrift
commented
Oct 2, 2023
| @@ -1,7 +1,9 @@ | |||
| # common | |||
|
|
|||
| Utilities commonly used by other packages. Each common utility lives in its own folder together with its documentation. | |||
| The implementation is re-exported by main entry of this package. The package consists of: | |||
| > Utilities commonly used by other packages. | |||
There was a problem hiding this comment.
To make it consistent with other packages.
Siegrift
commented
Oct 2, 2023
| debug: (message, context) => logger.debug(message, { context }), | ||
| info: (message, context) => logger.info(message, { context }), | ||
| warn: (message, context) => logger.warn(message, { context }), | ||
| debug: (message, context) => logger.debug(message, context ? { context } : undefined), |
There was a problem hiding this comment.
If you do not pass context, the logs previously had {context: undefined} which is unnecessary (and confusing).
Siegrift
commented
Oct 2, 2023
| ## Getting started | ||
|
|
||
| 1. If you are using Docker Desktop, you need to change the URL in `pusher/secrets.env` from `localhost` to | ||
| `host.docker.internal`, because pusher is running inside a Docker container. |
There was a problem hiding this comment.
Since the configurations are not gitignored it will modify source tree, but I don't think we need to care much.
Siegrift
commented
Oct 2, 2023
| # Secrets must NOT be quoted. | ||
| # | ||
| # Use "host.docker.internal" if using Docker for Desktop. | ||
| HOST_IP=localhost |
There was a problem hiding this comment.
Interpolated in config to make it easier to work with.
Siegrift
commented
Oct 2, 2023
| @@ -9,7 +9,7 @@ import { TemplateResponse } from '../sign-template-data'; | |||
| export const callApi = async (payload: node.ApiCallPayload) => { | |||
| logger.debug('Preprocessing API call payload', pick(payload.aggregatedApiCall, ['endpointName', 'oisTitle'])); | |||
| const processedPayload = await preProcessApiSpecifications(payload); | |||
| logger.debug('Performing API call', { processedPayload: processedPayload }); | |||
| logger.debug('Performing API call', pick(processedPayload.aggregatedApiCall, ['endpointName', 'oisTitle'])); | |||
Siegrift
commented
Oct 2, 2023
| @@ -50,8 +50,11 @@ export const makeTemplateRequests = async (signedApiUpdate: SignedApiUpdate): Pr | |||
| : callApi(operationPayload)); | |||
|
|
|||
| if (node.api.isPerformApiCallFailure(apiCallResponse)) { | |||
| const message = `Failed to make API call for the endpoint [${endpoint.oisTitle}] ${endpoint.endpointName}.`; | |||
| logger.warn(message, { operationTemplateId }); | |||
| logger.warn(`Failed to make API call`, { | |||
There was a problem hiding this comment.
Was missing error message.
Siegrift
commented
Oct 2, 2023
| @@ -50,7 +50,11 @@ export const postSignedApiData = async (group: SignedApiNameUpdateDelayGroup) => | |||
| logger.warn( | |||
| `Failed to make update signed API request.`, | |||
| // See: https://axios-http.com/docs/handling_errors | |||
| { ...logContext, error: goAxiosRequest.error.response ?? goAxiosRequest.error } | |||
| { | |||
There was a problem hiding this comment.
Was too spammy and also didn't have proper error message in certain network failures.
Siegrift
force-pushed
the
e2e
branch
2 times, most recently
from
12919eb to
59cb592
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52