Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to common ESlint configuration #68

Merged
merged 9 commits into from
Oct 9, 2023
Merged

Conversation

Siegrift
Copy link
Collaborator

@Siegrift Siegrift commented Oct 5, 2023

Related to api3dao/commons#3

The PR was created together with the ESLint configuration in commons and is a bit messy, because I was working on both packages simultaneously. Since then, the package has been published (v0.1.0) and this package was updated to use the version from NPM.

Most of the changes were fixed automatically. Others took a bit of time to finish.

@Siegrift Siegrift self-assigned this Oct 5, 2023
@Siegrift Siegrift requested a review from andreogle October 9, 2023 09:16
@Siegrift Siegrift changed the title WIP: Migrate to common ESlint configuration Migrate to common ESlint configuration Oct 9, 2023
@Siegrift Siegrift merged commit 71b83f0 into main Oct 9, 2023
4 checks passed
@Siegrift Siegrift deleted the eslint-unification branch October 9, 2023 09:21
Copy link
Member

@andreogle andreogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like a lot of these changes. Nice work

packages/api/src/handlers.test.ts Show resolved Hide resolved
packages/api/src/handlers.ts Show resolved Hide resolved
packages/api/src/schema.test.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants