Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement node version #94

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Implement node version #94

merged 4 commits into from
Oct 24, 2023

Conversation

Siegrift
Copy link
Collaborator

Closes #82

Rationale

Added nodeSettings.nodeVersion similar to the Airnode. I am not entirely happy with the naming, but sticked to the on used in Airnode. Also, I put the node version inside nodeSettings in anticipation for other fields (e.g. stage).

I also noticed that I didn't completely remove source maps in #64 so I removed the (no longer necessary) --enable-source-maps flag.

@Siegrift Siegrift requested a review from andreogle October 20, 2023 08:43
@Siegrift Siegrift self-assigned this Oct 20, 2023
@bbenligiray
Copy link
Member

In the Airnode config airnodeWalletMnemonic is also under nodeSettings https://github.com/api3dao/airnode/blob/master/packages/airnode-node/config/config.example.json#L68
rateLimiting only exists in Airseeker and it's at the config root for the lack of a nodeSettings field (https://github.com/api3dao/airseeker/blob/main/config/airseeker.example.json#L3), but I'd argue that if there is a nodeSettings field, rateLimiting should go under it

@Siegrift Siegrift merged commit fb5be4e into main Oct 24, 2023
4 checks passed
@Siegrift Siegrift deleted the node-version branch October 24, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pusher config should include nodeVersion
3 participants