Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitepress framework update 1.3.1 #784

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Vitepress framework update 1.3.1 #784

merged 7 commits into from
Jul 31, 2024

Conversation

wkande
Copy link
Member

@wkande wkande commented Jul 29, 2024

@dcroote This PR updates the docs to the latest release of Vitepress. I will be closing the renovate PR without merging it as this PR will be its replacement.

Four things to mention here:

  1. The framework update resulted in an update to the VPNavBar.vue component
  2. OEV was missing from the flex build, I added it
  3. Three OEV pages needed fixing
    Two pages had a bad frontmatter path
    Another page was missing the FlexStart and FlexEnd tags
  4. Lastly I have created another issue for a possible change to the config.js file. The new Vitepress release now has the ability to add custom components to the NavBar. In the past I had to hack the VPNavBar.vue component to add the search button. I am hoping that this new feature can be used to do so. I only worry about placement. We will see.

@wkande wkande requested review from dcroote and Ashar2shahid July 29, 2024 19:50
@wkande wkande self-assigned this Jul 29, 2024
Copy link
Contributor

Visit the preview URL for this PR (updated for commit d71c586):

https://vitepress-docs--pr784-framework-update-1-3-62d9vkng.web.app

(expires Mon, 05 Aug 2024 19:52:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (except the search results, but I know that's tied to how the files are pulled).

@wkande wkande merged commit 2739299 into main Jul 31, 2024
2 checks passed
@wkande wkande deleted the framework-update-1.3.1 branch July 31, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants