Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Integration: Remove custom Node setup in favor of Astro action #70

Merged
merged 9 commits into from
Jan 27, 2025

Conversation

vancura
Copy link
Collaborator

@vancura vancura commented Jan 27, 2025

Simplifying the GitHub Actions workflow by replacing the manual Node.js setup and build steps with the official Astro GitHub action. The withastro/action@v3 handles the installation, building, and artifact upload automatically, reducing potential points of failure and making the workflow more maintainable.

Fixes #69

Simplifying the GitHub Actions workflow by replacing the manual Node.js setup and build steps with the official Astro GitHub action. The `withastro/action@v3` handles the installation, building, and artifact upload automatically, reducing potential points of failure and making the workflow more maintainable.
@vancura vancura added bug Something isn't working top-priority labels Jan 27, 2025
@vancura vancura self-assigned this Jan 27, 2025
@vancura
Copy link
Collaborator Author

vancura commented Jan 27, 2025

Removing Sharp Dependency for GitHub Pages Compatibility

I've removed the sharp image processing dependency and configured Astro to use a passthrough image service instead. This change was necessary because Sharp has known installation issues in GitHub Pages' build environment. While this means we lose automatic image optimization during build time, it allows our site to build and deploy successfully on GitHub Pages. Our images will now be served in their original format and size.

We may need to revisit the issue later and find an image hosting solution (such as Imgix).

/c @netmilk

@vancura vancura merged commit de896d4 into main Jan 27, 2025
1 check passed
@vancura vancura deleted the bug/gh-69-github-styling branch January 27, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Pages styling problem
1 participant