Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pagination for AppGroups Apps-3x #307

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

shishir-intelli
Copy link
Collaborator

Implemented pagination for Apigee-X AppGroup Apps for 3x.
Fix issue showing 1000+ apps for Apigee X.
Closes #305

@shishir-intelli shishir-intelli added the enhancement New feature or request label Sep 11, 2023
@shishir-intelli shishir-intelli added this to the 3.0.1 milestone Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #307 (16e2305) into 3.x (6c54545) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #307      +/-   ##
============================================
- Coverage     87.61%   87.61%   -0.01%     
  Complexity     1727     1727              
============================================
  Files           348      349       +1     
  Lines          4620     4617       -3     
============================================
- Hits           4048     4045       -3     
  Misses          572      572              
Flag Coverage Δ
unittests 87.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/Api/ApigeeX/Controller/AppGroupAppController.php 60.00% <ø> (-11.43%) ⬇️
...rc/Api/ApigeeX/Controller/AppByOwnerController.php 100.00% <100.00%> (ø)

Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 7c19c35 into apigee:3.x Sep 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Implement pagination for Apigee X Teams Apps
2 participants