Mark psr/http-message >=2.0 supported #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #310 +/- ##
=========================================
Coverage 87.61% 87.61%
Complexity 1727 1727
=========================================
Files 349 349
Lines 4617 4617
=========================================
Hits 4045 4045
Misses 572 572
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Thank you @mxr576 for the PR and the description. Verified that Drupal 10 uses psr/http-message ^2.0 but due to apigee-client-php still using ^1.0, drupal downgrades psr/http-message to ^1.0 . For this PR Github action is failing with 2 error https://github.com/apigee/apigee-client-php/actions/runs/6247998648/job/16961690725?pr=310#step:10:666. Once the test are passed we can merge the PR. |
|
I'll get back to this PR, hopefully in the next 48 hours 🤞 |
|
@divya-intelli all green, back to you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Make installation on Apigee Edge module easier on Drupal 10+ projects was built with https://packagist.org/packages/drupal/core-recommended#10.1.3 that depends on https://packagist.org/packages/symfony/psr-http-message-bridge#v2.3.1.
What is the problem?
When a new clean Drupal 10+ project is created with
drupal/core-recommendedComposer picks the highest version of packages, including psr/http-message and it installs 2.0.0. Later when drupal/apigee_edge module gets installed, Composer needs convincing to downgrade to a previous version of psr/http-message because this package needs that. (Luckily the rest of the dependency chain also support 1.x.)Related: